fix: prevent non-node types from being output in the query analyzer list type keys #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen resolved from an interface
…hen resolved from an interface
|
Code Climate has analyzed commit 12fb5b2 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This prevents list types from being returned in the query analyzer if the type isn't a type that implements the
nodeinterface.failing test: https://github.com/wp-graphql/wp-graphql/actions/runs/3897357240/jobs/6654945889
passing test: https://github.com/wp-graphql/wp-graphql/actions/runs/3897472140/jobs/6655191024
Does this close any currently open issues?
closes #2690